Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shim: Don't stop forever at "Secure Boot not enabled" notification #438

Merged
merged 1 commit into from
Dec 10, 2021
Merged

shim: Don't stop forever at "Secure Boot not enabled" notification #438

merged 1 commit into from
Dec 10, 2021

Conversation

rmetrich
Copy link
Contributor

@rmetrich rmetrich commented Dec 3, 2021

Requesting a keystroke when Secure Boot is not enabled and verbosity is enabled is really annoying.

@rmetrich
shim: Don't stop forever at "Secure Boot not enabled" notification
124febd 
Requesting a keystroke when Secure Boot is not enabled and verbosity is
enabled is really annoying.

Signed-off-by: Renaud Métrich <rmetrich@redhat.com>
frozencemetery
frozencemetery reviewed Dec 6, 2021
View reviewed changes
Copy link
Member

@frozencemetery frozencemetery left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message mentions that "Requesting a keystroke... is really annoying", but it doesn't look like this patch fixes that - just adds mention that a keystroke is needed. Am I missing something?

@rmetrich
Copy link
Contributor Author

rmetrich commented Dec 7, 2021

The commit message mentions that "Requesting a keystroke... is really annoying", but it doesn't look like this patch fixes that - just adds mention that a keystroke is needed. Am I missing something?

Well yes,console_notify() requires hitting Enter to continue, so as soon as Verbose mode is set, the system will stop at the prompt and waiting for the user to hit Enter which prevents unattended boot.

@vathpela vathpela merged commit 0dd4c78 into rhboot:main Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frozencemetery frozencemetery frozencemetery left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rmetrich @frozencemetery @vathpela