Do not pass watermark option to ffmpeg because it is processed wrong #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rheaton
added a commit
that referenced
this pull request
May 16, 2014
Do not pass watermark option to ffmpeg because it is processed wrong
|
v 0.5.6 is our with your PR. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After https://github.com/streamio/streamio-ffmpeg has added own way to add watermark option
watermarkis processed with wrong way. So we should remove this option from options list before pass them to ffmpeg.It closes #23
It will be better in future to use native way to apply watermark.