add support for progress option to provide a method on your model that will passed be notified of processing progress #8

Merged
merged 2 commits into from Aug 8, 2013

Projects

None yet

2 participants

@svoynow
Contributor
svoynow commented Aug 7, 2013

StreamIO-ffmpeg supports a progress hook. All we needed to do was pass a block through to the transcode method.
It just goes in the options hash that you pass to encode_video, the value is a symbol that's the name of the the method on your model.

    process encode_video: [:mp4, callbacks: { after_transcode: :set_success } , 
                           logger: :logger, progress: :progress]

I think it's a really useful feature if you're doing asynchronous processing using something like https://github.com/lardawge/carrierwave_backgrounder

If anybody has any ideas on cleaning up the implementation, please let me know.

@rheaton
Owner
rheaton commented Aug 8, 2013

I will take a look at this tomorrow. Thanks!

@rheaton rheaton merged commit c1dfc5d into rheaton:master Aug 8, 2013

1 check passed

default The Travis CI build passed
Details
@rheaton
Owner
rheaton commented Aug 8, 2013

Bumped gem version to 0.5.0

@rheaton rheaton referenced this pull request Aug 28, 2013
Closed

Transcoding progress #5

@sphw sphw pushed a commit to sphw/carrierwave-video that referenced this pull request Dec 6, 2013
@rheaton Add progress hook in README and bump version
Thanks to @svoynow-lz
rheaton#8
83a0a87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment