Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for progress option to provide a method on your model that will passed be notified of processing progress #8

Merged
merged 2 commits into from
Aug 8, 2013

Conversation

svoynow
Copy link
Contributor

@svoynow svoynow commented Aug 7, 2013

StreamIO-ffmpeg supports a progress hook. All we needed to do was pass a block through to the transcode method.
It just goes in the options hash that you pass to encode_video, the value is a symbol that's the name of the the method on your model.

    process encode_video: [:mp4, callbacks: { after_transcode: :set_success } , 
                           logger: :logger, progress: :progress]

I think it's a really useful feature if you're doing asynchronous processing using something like https://github.com/lardawge/carrierwave_backgrounder

If anybody has any ideas on cleaning up the implementation, please let me know.

@rheaton
Copy link
Owner

rheaton commented Aug 8, 2013

I will take a look at this tomorrow. Thanks!

rheaton added a commit that referenced this pull request Aug 8, 2013
add support for progress option to provide a method on your model that will passed be notified of processing progress
@rheaton rheaton merged commit c1dfc5d into rheaton:master Aug 8, 2013
@rheaton
Copy link
Owner

rheaton commented Aug 8, 2013

Bumped gem version to 0.5.0

@rheaton rheaton mentioned this pull request Aug 28, 2013
sphw pushed a commit to sphw/carrierwave-video that referenced this pull request Dec 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants