Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Specify (SQL WHERE) search_condition, to filter the table for rows to be anonymized. #18

Merged
merged 3 commits into from
May 5, 2021

Conversation

bobslee
Copy link
Contributor

@bobslee bobslee commented May 5, 2021

No description provided.

@bobslee
Copy link
Contributor Author

bobslee commented May 5, 2021

@hkage please could you review my PR ? I really need to get this on PyPi.
Great tool by the way! Thanks!

@hkage
Copy link
Contributor

hkage commented May 5, 2021

Thanks for your PR @bobslee This is a great idea to narrow down the data that should be anonymized. I will take a look into all open pull requests today and make a new release if everything looks ok.

@hkage
Copy link
Contributor

hkage commented May 5, 2021

Looks good to me.

@hkage hkage merged commit 7a93c72 into rheinwerk-verlag:development May 5, 2021
@bobslee
Copy link
Contributor Author

bobslee commented May 5, 2021

Thanks @hkage

@bobslee
Copy link
Contributor Author

bobslee commented May 5, 2021

@hkage It seems my PR broke the docs TOC / index, see screenshot.
How to fix?

image

@hkage
Copy link
Contributor

hkage commented May 5, 2021

It seems like the code snippet had broken the TOC, but I don't know exactly why. I added a sub-section for all elements before the "Provider" section (b22cdfc#diff-7803db48064b8857ffa23bfa8cad7b59d218e9cc842f1b165551388118c30ac2R4) and the TOC seems to be correct.

documentation

The docs will be updated with the next release, I cannot re-upload the same version again on PyPi.

@bobslee
Copy link
Contributor Author

bobslee commented May 8, 2021

EDIT: Nevermind, I misunderstood... noticed you already committed this.

@hkage Would you like me to create an issue to update/fix the docs (TOC) ?
So it won't be forgotten.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants