Make chunk size in the table definition dynamic #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for your contribution. This looks like a nice way to overwrite the default cursor chunksize, especially for larger tables. I will take a look into the changes asap. We should add a small explanation of the new keyword for the Sphinx documentation, too but I can do that as soon as I have merged your pull request. |
|
Hi, could you please fix the flake8 warning before I merge your pull request? I would complement the documentation afterwards. And thanks again for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chunk size used while fetching data from source was hardcoded. I needed to change it according to the needs per table. This PR makes it dynamic in the schema definition.