Broken Python 2.7 compatibility #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I decided to remove the poetry setup because it is not intended to be used with Python 2.7 anymore (without further changes) and we are still using Python 2.7 on some servers, so that I cannot remove this compatibility. Therefore tox will be used for the test action and the local development has to be done by using simple virtualenvs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usage of f-strings recently broke the project's Python 2.7 compatibility which was added by intention. Unfortunately the Github tests didn't cover this incompatibility.
In addition to that the test action flow cannot handle the current poetry version / installer so that tests won't be executed properly (eg in this test run). The workflow has to be adjusted to the current poetry version or poetry has to be abolished in favor of simple requirement files and a Tox based testing setup.