Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit testing #126

Merged
merged 40 commits into from May 2, 2016
Merged

Unit testing #126

merged 40 commits into from May 2, 2016

Conversation

GJena
Copy link
Contributor

@GJena GJena commented Apr 16, 2016

What does this PR do?

Added 6 unit tests
Updated 1 unit test

Where should the reviewer start?

tests.py file

How should this PR be tested?

Travis-CI should automatically test the tests added

Any background context you want to provide?

What are the relevant issues?

#41

Screenshots (if appropriate)

Questions:

  • Do the docs need to be updated? No
  • Does this PR add new (Python) dependencies? No

@coveralls
Copy link

Coverage Status

Coverage increased (+3.7%) to 32.646% when pulling d2e6209 on GJena:unit-testing into a27985f on rhiever:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+4.5%) to 33.409% when pulling 7b27a9a on GJena:unit-testing into a27985f on rhiever:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+4.5%) to 33.409% when pulling 2e9e9e4 on GJena:unit-testing into a27985f on rhiever:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+5.2%) to 34.16% when pulling 6028960 on GJena:unit-testing into a27985f on rhiever:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+5.9%) to 34.787% when pulling 6028960 on GJena:unit-testing into a27985f on rhiever:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+6.2%) to 35.117% when pulling 3834b13 on GJena:unit-testing into a27985f on rhiever:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+6.8%) to 35.778% when pulling b359df2 on GJena:unit-testing into a27985f on rhiever:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+7.9%) to 36.877% when pulling 443a907 on GJena:unit-testing into a27985f on rhiever:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+8.8%) to 37.748% when pulling d32ad44 on GJena:unit-testing into a27985f on rhiever:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+16.0%) to 44.894% when pulling 3c2d823 on GJena:unit-testing into a27985f on rhiever:master.

@rhiever
Copy link
Contributor

rhiever commented Apr 18, 2016

Happy to see the coverage going up slowly but surely! 👍

@rhiever
Copy link
Contributor

rhiever commented Apr 18, 2016

@teaearlgraycold is adding unit tests for _rbf() (new feature preprocessing method), so don't worry about that one.

@coveralls
Copy link

Coverage Status

Coverage increased (+15.8%) to 44.742% when pulling 92f32fc on GJena:unit-testing into a27985f on rhiever:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+16.5%) to 45.418% when pulling a74b99b on GJena:unit-testing into a27985f on rhiever:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+16.5%) to 45.418% when pulling ab2e74a on GJena:unit-testing into a27985f on rhiever:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+18.6%) to 47.515% when pulling e945f5e on GJena:unit-testing into a27985f on rhiever:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+19.8%) to 48.738% when pulling bb89285 on GJena:unit-testing into a27985f on rhiever:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+19.8%) to 48.738% when pulling bb89285 on GJena:unit-testing into a27985f on rhiever:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+21.07%) to 50.0% when pulling 21782ff on GJena:unit-testing into a27985f on rhiever:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+21.6%) to 50.569% when pulling 31c5efd on GJena:unit-testing into a27985f on rhiever:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+22.2%) to 51.126% when pulling 1f70f42 on GJena:unit-testing into a27985f on rhiever:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+23.3%) to 52.186% when pulling 8fcaa79 on GJena:unit-testing into a27985f on rhiever:master.

@rhiever rhiever merged commit b4bd593 into EpistasisLab:master May 2, 2016
@rhiever
Copy link
Contributor

rhiever commented May 2, 2016

Going to go ahead and merge this PR. @GJena, when you have more unit tests ready, please open a separate PR. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants