Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERC1271 should not be limited to r,s,v signatures #15

Closed
zeroknots opened this issue Aug 14, 2023 · 1 comment
Closed

ERC1271 should not be limited to r,s,v signatures #15

zeroknots opened this issue Aug 14, 2023 · 1 comment
Assignees
@zeroknots
Labels
enhancement New feature or request

Comments

@zeroknots
Copy link
Member

The current ERC1271 checks only allow for r,s,v, signatures.

this breaks compatibility with multisigs or other signature schemas

https://github.com/rhinestonewtf/registry/blob/main/src/eip712/EIP712Verifier.sol#L217
@zeroknots zeroknots added the bug Something isn't working label Aug 14, 2023
@zeroknots zeroknots self-assigned this Aug 14, 2023
@zeroknots zeroknots added enhancement New feature or request and removed bug Something isn't working labels Aug 14, 2023
@zeroknots zeroknots mentioned this issue Aug 21, 2023
Merged
@kopy-kat
Copy link
Member

Resolved in PR #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zeroknots zeroknots

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kopy-kat @zeroknots