[RTT-5621] Support for Date & Time spoke in RHEL-10 #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstodola
reviewed
May 16, 2024
| if not radiobutton.checked: | ||
| if dryrun: | ||
| return Fail( | ||
| """Date & time mode is {mode_found} (NTP {state_found}), expected {mode_expected} """ |
There was a problem hiding this comment.
pyflakes complains that:
anabot/runtime/installation/hub/datetime/__init__.py:196:21: '...'.format(...) has unused arguments at position(s): 0, 1, 2, 3
anabot/runtime/installation/hub/datetime/__init__.py:196:21: '...'.format(...) is missing argument(s) for placeholder(s): mode_expected, mode_found, state_expected, state_found
jikortus
force-pushed
the
datetime-rhel-10
branch
from
ea83e7e
to
b4ac276
Compare
|
@jstodola Thank you, fixed. |
|
It looks good to me, thanks. |
jstodola
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links to testing jobs on RHEL-9 and 10 will be added to RTT-5621.