Skip to content

Commit

Permalink
install-{env,img}-deps: recommend/require kdump-anaconda-addon
Browse files Browse the repository at this point in the history
Way back in https://bugzilla.redhat.com/show_bug.cgi?id=1115914
and https://bugzilla.redhat.com/show_bug.cgi?id=1176483 , we
wanted to get this addon included in the install environment.
However, it wasn't really done properly. As things wound up, it
got listed in lorax runtime-install.tmpl (which does the job of
getting it in the 'traditional' installer environment, but not
getting it on live images), and then to get it on live images,
it was added to the anaconda-tools comps group.

This got the job done, but isn't correct. anaconda-tools is
meant to contain packages that the installer might need to
deploy to the installed system, not packages that should be in
the installer environment. It only wound up getting the package
installed in the live environment because we have to include
all packages from anaconda-tools in the lives because we have
no way to add packages to live installs at install time.

Adding this here is more correct, and would mean we only need to
list it in one place (here) instead of two (lorax templates and
comps).

Signed-off-by: Adam Williamson <awilliam@redhat.com>
  • Loading branch information
AdamWill committed Sep 26, 2023
1 parent acc8306 commit b91b606
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions anaconda.spec.in
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,8 @@ Requires: tmux
Requires: gdb
# support for installation from image and live & live image installations
Requires: rsync
# An addon that allows enabling kdump at install time
Recommends: kdump-anaconda-addon
# basic filesystem tools
%if ! 0%{?rhel}
Requires: btrfs-progs
Expand Down Expand Up @@ -234,6 +236,8 @@ Requires: fcoe-utils >= %{fcoeutilsver}
%endif
# only WeakRequires elsewhere and not guaranteed to be present
Requires: device-mapper-multipath
# only WeakRequires in -env-
Requires: kdump-anaconda-addon
%if ! 0%{?rhel}
Requires: zram-generator-defaults
%else
Expand Down

0 comments on commit b91b606

Please sign in to comment.