Catch exception when reading from in-memory connection being removed … #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M4rtinK
approved these changes
Apr 7, 2017
pyanaconda/nm.py
Outdated
| settings = proxy.GetSettings() | ||
| except Exception as e: | ||
| log.debug("nm_get_all_settings: %s", e) | ||
| continue |
There was a problem hiding this comment.
I think it would good to add a note why we are doing this - basically the content of the commit message. :)
…(#1439051) This can happen when a connection is removed by NM between we obtain connection objects and try to read settings from them.
rvykydal
force-pushed
the
f26-devel-make-reading-connections-more-robust
branch
from
f991dad
to
865c0cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…(#1439051)
This can happen when a connection is removed by NM between we obtain connection
objects and try to read settings from them.