Fix a log-related rename mixup #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins, test this please |
2 similar comments
|
jenkins, test this please |
|
jenkins, test this please |
jkonecny12
approved these changes
Jun 6, 2017
pyanaconda/kickstart.py
Outdated
| @@ -1125,7 +1125,9 @@ def execute(self, *args): | |||
| # not set from the command line | |||
| level = anaconda_logging.logLevelMap[self.level] | |||
| anaconda_logging.logger.loglevel = level | |||
| anaconda_logging.setHandlersLevel(anaconda_logging, level) | |||
| # set log level for the "anaconde" root logger | |||
Turns out there are still cases where working directly with the "anaconda" root logger makes sense, such as setting it's log level.
In this case we want to set the log level of the "anaconda" root logger, but this apparently got mixed up during the anaconda_log -> anaconda_logging rename and subsequent switch to structured logging. So fix the mixup and correctly use the "anaconda" root logger in the setHandlersLevel() call.
M4rtinK
force-pushed
the
master-fix_kickstart_logging
branch
from
23085c1
to
878ab21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit adds a getter for the "anaconda" root logger and the second commit fixes the actual mixup.