rpmostreepayload: Reuse the local repo as a cache #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a WIP since the API hasn't landed in libostree yet, but I tested this and it works nicely! |
cgwalters
changed the title
When doing kickstart installs (can happen for both bare metal PXE as well as building cloud images), we currently end up redownloading all of the ostree content, even though we have a version in the squashfs already. However, the version we have may not be the version we want; the installer image is typically built at a different/slower cycle from the ostree content. But this is where a strength of libostree's content-addressed storage shines; we can use the local repo as an object cache, and avoid fetching what we already have. This just enables the logic that lives in libostree. Closes: https://github.com/rhinstaller/anaconda/issues/1117
jkonecny12
approved these changes
Jun 30, 2017
|
Jenkins, it's ok to test. |
cgwalters
force-pushed
the
rpmostree-localcache
branch
from
6f37116
to
f5263d4
Compare
|
The upstream PR was merged, removing WIP. Note that I added a version check, so we'll work with both old and new versions. Hence this should be safe to merge at any time. libostree releases usually are on a 3-4 week cadence, so it'll be a week or two. |
cgwalters
changed the title
M4rtinK
approved these changes
Jul 3, 2017
|
For reference the OSTree PR is: ostreedev/ostree#982 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing kickstart installs (can happen for both bare metal PXE as well as
building cloud images), we currently end up redownloading all of the ostree
content, even though we have a version in the squashfs already.
However, the version we have may not be the version we want; the installer image
is typically built at a different/slower cycle from the ostree content.
But this is where a strength of libostree's content-addressed storage shines; we
can use the local repo as an object cache, and avoid fetching what we already
have.
This just enables the logic that lives in libostree: ostreedev/ostree#982
Closes: https://github.com/rhinstaller/anaconda/issues/1117