Add kickstart test to test vlan creation #115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkonecny12
force-pushed
the
master-test-net-vlan
branch
from
7c25a86
to
54087ad
Compare
| %end | ||
|
|
||
| %post | ||
| CONTENT=$(cat /etc/sysconfig/network-scripts/$(ls /etc/sysconfig/network-scripts/ | grep ".150")) |
There was a problem hiding this comment.
I think you don't need to read the whole file here you can just get its name and then copy it. Then use the file name for the sed below to get the device. Also the second part of this could use a * pattern instead of the grep.
|
Other than the above this looks good to me. |
|
Yeah, looks good to me now too. |
|
Thank you for your responses. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps of testing:
network --device=link --vlanid=150 --bootproto=dhcpks commandI'm saving content of the configuration file and name of the vlan device to special file for debugging purpose.