Add kickstart tests to test btrfs installation #118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't have time to do a proper review right now, but I did notice one thing that dlehman and I talked about the other day. I don't think you want to start the filenames with "storage-", because it's just going to make tab completion more obnoxious. It's obvious that it's storage on the basis on it being a btrfs-related thing. |
|
I agree with @clumens. If we want to mark tests as storage-related, we could put them in a subdirectory. Other then that, I'm just not sure about the installation source |
First test: simple installation Second test: installation over multiple devices with RAID Signed-off-by: Vojtech Trefny <vtrefny@redhat.com>
vojtechtrefny
force-pushed
the
master_kickstart_tests
branch
from
c62f4da
to
6850f77
Compare
|
Updated version:
|
|
Looks good to me. |
|
Totally forgot to push this... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First test: simple installation
Second test: installation over multiple devices with RAID
Signed-off-by: Vojtech Trefny vtrefny@redhat.com