rpmostreepayload: Substitute ${basearch} in ostreesetup ref

[cgwalters]

See: https://pagure.io/atomic-wg/issue/299

Basically for multi-arch systems like Fedora it's convenient
to be able to reuse the same kickstart across multiple architectures.

This requires a new rpmostree API: coreos/rpm-ostree#877
(So be careful about backporting this; if we do that I may try
to have it check for the API availability)

[cgwalters]

Tested locally against https://kojipkgs.fedoraproject.org/compose/branched/Fedora-27-20170912.n.0/compose/Atomic/x86_64/iso/Fedora-Atomic-ostree-x86_64-27-20170912.n.0.iso using an updates.img from the f27-devel branch.

[cgwalters]

And I changed my local kickstart test to do:

ostreesetup --nogpg --osname=fedora-atomic --remote=fedora-atomic --url=http://192.168.122.1:8000/repomirror/repo --ref=fedora/26/${basearch}/atomic-host

[dustymabe]

LGTM

[rvykydal]

Looks good to me.

[jkonecny12]

Looks good to me too.

[jkonecny12]

Jenkins, it's ok to test.

[cgwalters]

http://jenkins.install.bos.redhat.com/job/anaconda-f27-mock-PR/179/ ➡️ http://jenkins.install.bos.redhat.com/job/anaconda-f27-mock-PR/179/artifact/result/tests/nosetests.log ➡️

AssertionError: <pyanaconda.kickstart.RepoData object at 0x7fe29d565e80> is not an instance of <class 'pykickstart.commands.repo.F27_RepoData'>

which looks unrelated to this?

[rvykydal]

Yes it is unrelated, it is pykickstart and anaconda builds not being in sync.

[dustymabe]

Yes it is unrelated, it is pykickstart and anaconda builds not being in sync.

so can we merge? or do we need to wait for that to be fixed?

[rvykydal]

jenkins, test this please

[rvykydal]

@dustymabe
Can this go to F27 (is rpm-ostree related change there)? Or was it intended just for master.

[dustymabe]

Can this go to F27 (is rpm-ostree related change there)? Or was it intended just for master.

Definitely would like to see this in F27 as well.