Use the adapted Timezone class for kickstart data #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Servers are just URLs in 'timezone --ntpservers', pools are URLs entered 4 times in 'timezone --ntpservers'. Anaconda should make sure such transformation happens. Signed-off-by: Vratislav Podzimek <vpodzime@redhat.com>
|
The test got already reviewed on the anaconda-patches mailing list, but when I wanted to test it before pushing it revealed the issue that the pykickstart PR and this one fix. |
Otherwise we cannot distinguish NTP servers from pools because the old version stores them in a set and discards duplicate hostnames.
vpodzime
force-pushed
the
master-ntp_pools_kickstart
branch
from
f288ddc
to
ed32583
Compare
|
Added the bump of the required version of pykickstart and fixed the commit message. The pykickstart part has been merged and I consider this a trivial change. Pushing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the pykickstart PR 13