Add the boot option inst.xtimeout #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Resolves the issue https://github.com/rhinstaller/anaconda/issues/1237 |
jkonecny12
approved these changes
Nov 22, 2017
data/anaconda_options.txt
Outdated
| @@ -107,6 +107,9 @@ the password needs to be 6 to 8 characters long (limitation of the VNC protocol) | |||
| xdriver | |||
| Use DRIVER as the X driver to use during installation as well as on the installed system. | |||
|
|
|||
| xtimeout | |||
| Specify the timeout in seconds for starting X. | |||
There was a problem hiding this comment.
I would add X server to be more precise.
docs/boot-options.rst
Outdated
| inst.xtimeout | ||
| ^^^^^^^^^^^^^ | ||
|
|
||
| Specify the timeout in seconds for starting X. |
poncovka
force-pushed
the
master-xtimeout
branch
from
63aeb7d
to
6076b69
Compare
jkonecny12
reviewed
Nov 24, 2017
pyanaconda/iutil.py
Outdated
| @@ -48,7 +48,7 @@ | |||
| from gi.repository import GLib | |||
|
|
|||
| from pyanaconda.flags import flags | |||
| from pyanaconda.constants import DRACUT_SHUTDOWN_EJECT, TRANSLATIONS_UPDATE_DIR, UNSUPPORTED_HW, IPMI_ABORTED | |||
| from pyanaconda.constants import DRACUT_SHUTDOWN_EJECT, TRANSLATIONS_UPDATE_DIR, UNSUPPORTED_HW, IPMI_ABORTED, X_TIMEOUT | |||
There was a problem hiding this comment.
One last small thing, could you please wrap this line to 99 characters before merge. Thanks.
|
It looks even better now :). |
Added a new boot option inst.xtimeout to set the timeout in seconds for starting X server. (cherry-picked from a commit 08afa5c)
poncovka
force-pushed
the
master-xtimeout
branch
from
6076b69
to
f7b6071
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new boot option inst.xtimeout to set the timeout in seconds
for starting X.
(cherry-picked from a commit 08afa5c)