Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rhel7 rebase otherbugs #126

Closed
wants to merge 8 commits into from

Conversation

bcl
Copy link
Contributor

@bcl bcl commented Jun 3, 2015

No description provided.

bcl and others added 7 commits June 4, 2015 08:21
Remove the dnf payload completely.

Related: rhbz#1196721
This allows us to capture the mock logs in jenkins, among other things.

(cherry picked from commit bdb4a0f)

Related: rhbz#1196721
Otherwise it'll get hung up failing to download some package that exists.

(cherry picked from commit 097771e)

Related: rhbz#1196721
Gtk-doc is the worst at autotools integration. Allow me to enumerate:

  - It adds an option to our autoconf script that causes everything to
    fail if it is disabled. It is disabled by default.

  - It's driven through an opaque Makefile that forces docs to be built
    at source distribution time.

  - It requires the library to be built before it can generate docs, so
    it requires a full build before a source tarball can be created.

  - ...and it doesn't set up any Makefile dependencies at all, so it
    just fails if you forget to do a build first.

  - In fact, it's pretty crummy about keeping track of the dependencies
    for its own generated files. If you add or remove one of the source
    files that docs are generated from, you pretty much just have to do
    a git clean and start over.

  - It pulls in a ton of dist-time dependencies for other docs packages
    so that it can generate cross references but it still doesn't have
    cross reference data for half the stuff in glib because it sucks.

Get rid of gtk-doc's automatically installed files, where most of the
problems lie. Adapt the rules from gtk-doc.make into a single script
that runs everything to reduce the dependency nightmare. Run the script
at build time.

(cherry picked from commit ab2e32b)

Related: rhbz#1196721
Hidden defaults to True so you need to set it to False when there isn't
a match.

Related: rhbz#1196721
@vpodzime
Copy link
Contributor

vpodzime commented Jun 5, 2015

Looks good to me.

@vpodzime vpodzime added the ACK label Jun 5, 2015
@bcl
Copy link
Contributor Author

bcl commented Jun 5, 2015

pushed

@bcl bcl closed this Jun 5, 2015
@bcl bcl deleted the rhel7-rebase-otherbugs branch June 5, 2015 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants