Fix Repository New_Repository has no mirror or baseurl (#1215963) #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Source spoke is set to error state instead of crash with empty repository. "URL is empty" warning message is now working correctly. It shows if new repository is created or url is not set. Resolves: rhbz#1215963
| @@ -1328,6 +1328,8 @@ def on_addRepo_clicked(self, button): | |||
| self._repoSelection.select_iter(itr) | |||
| self._repoEntryBox.set_sensitive(True) | |||
|
|
|||
| self._repoURLChecks[repo].update_check_status() | |||
There was a problem hiding this comment.
In the Python 3 repo is not hashable and we use repo.name as the key. Just please sync with @M4rtinK to make sure whatever goes last has this glitch fixed.
|
Looks good to me otherwise. |
|
Other than the two comments this seems to work fine. Since it bypasses GUIInputCheck, the delayed check changes don't affect it. It might be possible to make the addon repo checks use the delay, but that's something we can look at later. |
|
Will be reworked and after that new PR will be created (with the link to this one :) ). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source spoke is set to error state instead of crash with empty
repository.
"URL is empty" warning message is now working correctly. It shows
if new repository is created or url is not set.
Resolves: rhbz#1215963