Always run anaconda private dbus session #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins, test this please |
poncovka
approved these changes
Mar 5, 2018
data/dbus/session.conf
Outdated
|
|
||
| Author(s): Jiri Konecny <jkonecny@redhat.com | ||
| --> | ||
|
|
There was a problem hiding this comment.
Please, change the name of the file.
There was a problem hiding this comment.
The config file looks to be too strict, but that is fine for now.
There was a problem hiding this comment.
We can change the policy anytime we want.
jkonecny12
force-pushed
the
f28-dev-always-run-anaconda-dbus-session
branch
from
74329fb
to
9078a4b
Compare
Configurations are placed in /usr/share/anaconda/dbus/confs DBus service files are placed in /usr/share/ananconda/dbus/services And main configuration file is placed in /usr/share/anaconda/dbus Thanks to this change we can setup permission as we need and change them when we need. Also it will avoid situations when user connects to a module and change its settings in an unexpected way. As a bonus for debugging we can easily trace traffic on our DBus without interference of other services. Related: rhbz#1551096
Do not use DBUS_SESSION_BUS_ADDRESS anymore because we now have our private session in all cases. Related: rhbz#1551096
We don't need this when we are running our own DBus session all the time. Resolves: rhbz#1551096
The process python object return None if the process is still running not otherwise.
jkonecny12
force-pushed
the
f28-dev-always-run-anaconda-dbus-session
branch
from
9078a4b
to
20858c5
Compare
|
UPDATED:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have our private DBus with our specific configuration.
Our private DBus is launched every time when Anaconda is started.
We are using our dbus variable instead of
DBUS_SESSION_BUS_ADDRESS.