Create the auto partitioning module #1458
Conversation
| @property | ||
| def passphrase(self): | ||
| """Default passphrase for all encrypted devices.""" | ||
| return self._passphrase |
There was a problem hiding this comment.
This just feels weird to me. I know we need it now, but we shouldn't provide password back from module. I don't think we will really need that when this spoke is finished.
So could you please add TODO here to remove getter when module will be completed please?
There was a problem hiding this comment.
Yeah, something similar to the note in the user module could be used:
https://github.com/rhinstaller/anaconda/blob/master/pyanaconda/modules/user/user_interface.py#L66
One more reason to concentrate on moving the logic on these modules as soon as possible. :)
There was a problem hiding this comment.
Fixed in the DBus interface.
| def SetEnabled(self, enabled: Bool): | ||
| """Is the auto partitioning enabled? | ||
|
|
||
| :param enabled: a boolean value |
There was a problem hiding this comment.
I think this can go away (or tell about semantics, not type).
poncovka
force-pushed
the
master-autopartitioning
branch
from
096413d
to
ba03bfc
Compare
|
Fixed some small issues. |
poncovka
force-pushed
the
master-autopartitioning
branch
from
ba03bfc
to
6be9c0b
Compare
The auto partitioning module can handle the autopart kickstart command and provides API for its options. The module is static for now, but it will be dynamic in the future.
Add new tests for the auto partitioning module and the autopart command.
poncovka
force-pushed
the
master-autopartitioning
branch
from
6be9c0b
to
86bfe33
Compare
he auto partitioning module can handle the autopart kickstart command
and provides API for its options. The module is static for now, but it
will be dynamic in the future.
Add new tests for the auto partitioning module and the autopart
command.