Fix KS logvol metadata and chunksize parameters (#1572511) #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkonecny12
force-pushed
the
modular-dev-fix-ks-lvm-command
branch
from
151f687
to
e71c08e
Compare
|
It changed when the lvm classes were rewritten to support changing lv types, eg: from normal lv to thin pool data/metadata lv. (See storaged-project/blivet@9b4f0609) We should have caught this then. Sorry about that. |
|
jenkins, test this please |
Thanks to our technique how we are passing parameters to blivet and how blivet requires them this was broken for a long time. The blivet changed when lvm classes were rewritten to support changing lv types. You can find out more here: storaged-project/blivet@9b4f0609 Resolves: rhbz#1572511
jkonecny12
force-pushed
the
modular-dev-fix-ks-lvm-command
branch
from
e71c08e
to
ecee90d
Compare
|
Updated commit comment and rebased. |
|
jenkins, test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to our technique how we are passing parameters to blivet and how blivet requires them this was broken for a long time. My theory is that this is broken when blivet renamed everything for PEP-8.
Resolves: rhbz#1572511