Run an installation task to install a language #1502
Conversation
| @@ -0,0 +1,40 @@ | |||
| # | |||
There was a problem hiding this comment.
What about having all the tasks in modules/<module_name>/tasks subfolder. So in this case it would be modules/localization/tasks/installation.py?
There was a problem hiding this comment.
I am not sure about this. I would prefer to sort tasks by their functionality. For example in the storage module, you don't want to have all tasks in pyanaconda.modules.storage.tasks, but you might want to keep them close to other related files, for example the bootloader tasks should be in pyanaconda.modules.storage.bootloader.
There was a problem hiding this comment.
And what about sorting then inside of that subfolder?
There was a problem hiding this comment.
We agreed that tasks will not be in a subfolder tasks.
| return "Configure language" | ||
|
|
||
| def run(self): | ||
| write_language_configuration(self._lang, self._sysroot) |
There was a problem hiding this comment.
Why the write_language_configuration() method is not part of this task? I don't think it should be run outside of the task or should it be?
There was a problem hiding this comment.
Ok, I can move it there.
|
jenkins, test this please |
poncovka
force-pushed
the
modularization-devel-install_lang
branch
from
1ada473
to
7e17797
Compare
The lang command will run a remote installation task to install a language on the installed system.
poncovka
force-pushed
the
modularization-devel-install_lang
branch
from
7e17797
to
c5ae710
Compare
Added new tests for the localization module changes and the task.
poncovka
force-pushed
the
modularization-devel-install_lang
branch
from
c5ae710
to
733a488
Compare
|
Updated: Created a specific exception and added new tests for the module and the task. |
The lang command will run a remote installation task to install
a language on the installed system.