Ask for encryption passphrase when not specified in ks (#1185466) #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -330,7 +340,7 @@ def _doExecute(self): | |||
| hubQ.send_message(self.__class__.__name__, _("Failed to save storage configuration...")) | |||
| self.data.bootloader.bootDrive = "" | |||
| else: | |||
| if self.autopart: | |||
| if self.autopart or (flags.automatedInstall and (self.data.autopart.autopart or self.data.partition.seen)): | |||
There was a problem hiding this comment.
Please add a comment below this line that self.run() is actually "run the storage check". That would make things a lot clearer, I think.
|
Looks good to me other than the suggestion above. |
Kickstart installation fails when '--encrypted' is used without specifying '--passphrase'. This patch marks the storage spoke as unready and asks for a passphrase. Resolves: rhbz#1185466 Signed-off-by: Vojtech Trefny <vtrefny@redhat.com>
vojtechtrefny
force-pushed
the
rhel7-branch_ks-passphrase
branch
from
eb81053
to
ca7808d
Compare
|
Pushed. |
|
Any chance of this bugfix making it into an Anaconda branch for Fedora? fedora 21 was broken like this too. (thanks for the RHEL fix though!) |
|
@vectorsigma This will of course go to Fedora 23 (and newer) too. Beacause we are not updating Fedora installation images, we can't update Anaconda in older versions of Fedora. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New (and I hope better) version of #140
Kickstart installation fails when '--encrypted' is used without
specifying '--passphrase'. This patch marks the storage spoke as
unready and asks for a passphrase.
Resolves: rhbz#1185466
Signed-off-by: Vojtech Trefny vtrefny@redhat.com