network: create systemd .link files for ifname= boot options (#1695894) #1940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't rely on initscripts renaming a device based on DEVICE and HWADDR values in ifcfg file as initscripts may not be installed. Instead, use systemd .link configuration file mechanism.
poncovka
approved these changes
Apr 8, 2019
jkonecny12
approved these changes
Apr 9, 2019
| for ifname_value in ifname_option_values: | ||
| iface, mac = ifname_value.split(":", 1) | ||
| content = self.INTERFACE_RENAME_FILE_CONTENT_TEMPLATE.format(mac, iface) | ||
| file_path = self.INTERFACE_RENAME_FILE_TEMPLATE.format(iface) |
There was a problem hiding this comment.
Just an idea.
Wouldn't it be better to have methods to create a string from these templates. These methods could have a documented arguments so it would be easier to not miss {} in a templates.
There was a problem hiding this comment.
I'd do it if/when the function will have more than one caller. For now I think it is ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't rely on initscripts renaming a device based on DEVICE and HWADDR
values in ifcfg file as initscripts may not be installed. Instead, use systemd
.link configuration file mechanism.