Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide spokes with the Anaconda configuration file #1981

Merged
merged 4 commits into from Jun 13, 2019

Conversation

poncovka
Copy link
Contributor

@poncovka poncovka commented May 27, 2019

Run a new installation task of the Services module to configure
the post-installation tools. It will enable or disable post-install
tools via the user interaction configuration file.

Add a new option hidden_spokes in the UI section of the Anaconda
configuration file and use it to hide spokes in UI. Don't use the
user interaction file for that.

Remove the support for the screen access management. It is not
necessary to generate data about visited spokes anymore and the
spokes can be hidden with the Anaconda configuration file.

Hide some of the spokes in variants Silverblue and Workstation Live.

@poncovka poncovka added master Please, use the `f39` label instead. manual testing required This issue can't be merged without manual testing labels May 27, 2019
@poncovka
Copy link
Contributor Author

poncovka commented May 27, 2019

TODO:

  • Add tests for the installation task.
  • Figure out how to handle the Workstation variant - some spokes are hidden only for live installations.

Run a new installation task of the Services module to configure
the post-installation tools. It will enable or disable post-install
tools via the user interaction configuration file.
Add a new option hidden_spokes in the UI section of the Anaconda
configuration file and use it to hide spokes in UI. Don't use the
user interaction file for that.
Remove the support for the screen access management. It is not
necessary to generate data about visited spokes anymore and the
spokes can be hidden with the Anaconda configuration file.
Hide some of the spokes in variants Silverblue and Workstation Live.
@poncovka poncovka removed the manual testing required This issue can't be merged without manual testing label Jun 11, 2019
@poncovka
Copy link
Contributor Author

Rebased and added tests.

Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@poncovka poncovka merged commit e5fe6ec into rhinstaller:master Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master Please, use the `f39` label instead.
2 participants