Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always schedule the installation task for joining realm (#1732620) #2052

Merged
merged 1 commit into from Jul 25, 2019
Merged

Always schedule the installation task for joining realm (#1732620) #2052

merged 1 commit into from Jul 25, 2019

Conversation

poncovka
Copy link
Contributor

@poncovka poncovka commented Jul 24, 2019 •
edited

We don't know the result of the realm discovery during the scheduling,
because the task for the realm discovery hasn't run yet. So always
schedule the task for joining the realm and check the result there.

Resolves: rhbz#1732620

@poncovka poncovka added the master Please, use the `f39` label instead. label Jul 24, 2019
jkonecny12
jkonecny12 reviewed Jul 25, 2019
View reviewed changes
Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the code perspective it's good. However, I'm missing information why we don't know result of the realm discovery. Could you please write it in the commit or write there that we don't know the reason, please.

@poncovka
Always schedule the installation task for joining realm (#1732620)
0ceb5d0 
We don't know the result of the realm discovery during the scheduling,
because the task for the realm discovery hasn't run yet. So always
schedule the task for joining the realm and check the result there.

Resolves: rhbz#1732620
@poncovka
Copy link
Contributor Author

The commit message was updated.

jkonecny12
jkonecny12 approved these changes Jul 25, 2019
View reviewed changes
Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me now, thanks!

@poncovka poncovka merged commit f6fb3c0 into rhinstaller:master Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkonecny12 jkonecny12 jkonecny12 approved these changes

Assignees
No one assigned
Labels
master Please, use the `f39` label instead.
Milestone
No milestone
2 participants
@poncovka @jkonecny12