Fix possible to start installation without network (#1221109) #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| def apply(self): | ||
| _update_network_data(self.data, self.network_control_box) | ||
| log.debug("network: apply ksdata %s", self.data.network) | ||
| self.network_control_box.kill_nmce(msg="leaving network spoke") | ||
|
|
||
| # if installation media is not used try if source is reachable | ||
| if self.data.method.method != "cdrom" and self._network_change: |
There was a problem hiding this comment.
hd is another possible non-network source.
There was a problem hiding this comment.
True. I'll change it locally.
jkonecny12
force-pushed
the
master-source-network-detection
branch
from
0bdd0b2
to
4a06127
Compare
|
Add check for harddrive too. |
|
Note that on this PR, the jenkins results are correct (even if it tested too much - don't know what's up with that). There are some pylint problems. |
Payload manager is started from network spoke if network settings change. This will start source spoke and software spoke reach-ability testing. Resolves: rhbz#1221109
jkonecny12
force-pushed
the
master-source-network-detection
branch
from
4a06127
to
d239863
Compare
|
Yeah I already fixed it. Thank you for this PR testing @clumens . |
|
Looks good. |
|
Pushed. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Payload manager is started from network spoke if network settings change.
This will start source spoke and software spoke reach-ability testing.
Resolves: rhbz#1221109