Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't mark the network command as removed #2180

Merged
merged 1 commit into from Oct 15, 2019
Merged

Don't mark the network command as removed #2180

merged 1 commit into from Oct 15, 2019

Conversation

poncovka
Copy link
Contributor

The network command uses its own parse method, so it cannot be marked
as removed yet.

@poncovka
Don't mark the network command as removed
1ef92cb 
The network command uses its own parse method, so it cannot be marked
as removed yet.
@poncovka poncovka added the master Please, use the `f39` label instead. label Oct 15, 2019
jkonecny12
jkonecny12 approved these changes Oct 15, 2019
View reviewed changes
Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

M4rtinK
M4rtinK approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well.

@poncovka poncovka merged commit d2e7a75 into rhinstaller:master Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M4rtinK M4rtinK M4rtinK approved these changes

@jkonecny12 jkonecny12 jkonecny12 approved these changes

Assignees
No one assigned
Labels
master Please, use the `f39` label instead.
Milestone
No milestone
3 participants
@poncovka @M4rtinK @jkonecny12