Remove the storage object from TUI #2193
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poncovka
added
master
Don't create the local storage object in the Anaconda class. We will use the Storage module instead.
Remove the support for reset of the local storage object. Run the DBus task of the Storage module instead.
Use the Storage module instead.
Use the Storage module instead.
Don't initialize and set up the local storage object during the start of anaconda. Use the Storage module instead.
Set up the Storage module instead.
Call the method CreateWithTask of the Snapshot module to create the pre-installation snapshot.
Use the Storage module instead.
Use the Storage module instead.
Use the Storage module instead.
Use device names instead.
Some of the functions for the storage initialization are used by UI, so they should use the Storage module instead of the local storage object.
The class DasdFormatting should use only the Storage module.
Use DBus tasks of the Storage module for the storage and bootloader configuration.
|
The pylint issues in GUI will be fixed in the next PR. |
jkonecny12
approved these changes
Oct 22, 2019
pyanaconda/storage/utils.py
Outdated
| @@ -473,9 +475,9 @@ def filter_disks_by_names(disks, names): | |||
|
|
|||
| :param disks: a list of disks | |||
| :param names: a list of disk names | |||
| :return: a list of filtered disks | |||
| :return: a list of filtered names | |||
There was a problem hiding this comment.
Please write here disk names.
pyanaconda/storage/utils.py
Outdated
| ] | ||
| # Get ancestors. | ||
| ancestor_names = filter_disks_by_names(disks, [ | ||
| a for d in selected_disks for a in device_tree.GetDeviceAncestors(d) |
There was a problem hiding this comment.
Could you please rewrite this part. The for...for syntax is pretty confusing.
pyanaconda/storage/utils.py
Outdated
| :param storage: an instance of the storage | ||
| :param selected: a list of selected disks | ||
| :param disks: a list of named of selected disks |
There was a problem hiding this comment.
I guess you have a typo here: a list of named should probably be a list of names.
Some of the functions of the storage utils are used by UI, so they should use the Storage module instead.
Use the Storage module instead.
Remove the implementation of the function configure_storage.
All storage-related kickstart data are generated by the Storage module now.
All storage-related kickstart commands are handled by the Storage module now.
The partitioning module has to be applied in the Storage module to be used. The Enabled property is useless now.
The UI creates the partitioning modules on demand, so there should be no pre-created ones.
Remove the local storage object from some parts of GUI to fix the pylint issues.
poncovka
force-pushed
the
master-remove_storage_tui
branch
from
6400ca8
to
bf73309
Compare
|
Updated. |
|
Still looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE!
TODO: