Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert VG reserved_space to Size #2225

Merged

Conversation

vojtechtrefny
Copy link
Contributor

We get amount of reserved space in MiB from kickstart but blivet
needs Size.

#2224 for master. This is related to storaged-project/blivet#813 but it's not necessary to merge/build these together.

@vojtechtrefny vojtechtrefny added the master Please, use the `f39` label instead. label Nov 20, 2019
Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using format in the newer Anaconda code.

Thanks for your PR!

Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now. Thanks!

We get amount of reserved space in MiB from kickstart but blivet
needs Size.
@vojtechtrefny
Copy link
Contributor Author

Rebased to latest master.

@poncovka poncovka merged commit c64ac0e into rhinstaller:master Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master Please, use the `f39` label instead.
3 participants