Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not crash on disk.wwn value being None (#1711571) #2263

Merged
merged 1 commit into from Jan 9, 2020
Merged

Do not crash on disk.wwn value being None (#1711571) #2263

merged 1 commit into from Jan 9, 2020

Conversation

rvykydal
Copy link
Contributor

@rvykydal rvykydal commented Jan 8, 2020

No description provided.

@rvykydal rvykydal added the master Please, use the `f39` label instead. label Jan 8, 2020
poncovka
poncovka approved these changes Jan 8, 2020
View reviewed changes
Copy link
Contributor

@poncovka poncovka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

jkonecny12
jkonecny12 approved these changes Jan 8, 2020
View reviewed changes
Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@rvykydal rvykydal force-pushed the do-not-crash-on-disk-wwn-None branch from 90cd6cc to d9c2d37 Compare January 8, 2020 12:58
@rvykydal
Copy link
Contributor Author

rvykydal commented Jan 8, 2020

jenkins, test this please

@rvykydal rvykydal merged commit 585f9c4 into rhinstaller:master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkonecny12 jkonecny12 jkonecny12 approved these changes

@poncovka poncovka poncovka approved these changes

Assignees
No one assigned
Labels
master Please, use the `f39` label instead.
Milestone
No milestone
3 participants
@rvykydal @jkonecny12 @poncovka