Fix the help button mnemonic display on spokes #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setup the help button label modifier every time the screen changes instead of only when entering a hub or standalone spoke.
|
Forgot to mention: this can, and probably should, be cherry-picked to f22-branch as well, though I have not yet created a bug for it. |
|
Looks good to me. |
|
Rebased and merged, but leaving the pull request open to remind to cherry-pick to f22 |
|
Cherry-picked to f22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you hold "Alt" on a hub or standalone spoke, the "Help!" label will change to "Help! (F1)". If you hold Alt on a normal spoke, this does not happen. This patch fixes that by moving the mnemonics listener into the method that changes the window that is visible in the stack.