fix the URL check for URLs with IPv6 literals #238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related: rhbz#1246133
This way when it's combined with something else (like the hostname regex), all the pipes don't mess up the surrounding regex. Resolves: rhbz#1246133
|
Darn, too bad this version doesn't have the ci target, would be nice to see jenkins test the new tests :) |
|
Because of this I remember that I want to remove this regex madness of IP addresses (which doesn't cache all) and add IPy package instead of it. But this commit is alright so push it and I will change it on top of the master. |
|
Pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.