Fix Initial PPC PReP Boot Selector Name (#1172755) #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The auto partition tool added the PPC PReP Boot partition and named it prepboot in the selector view in the GUI installer. This was due to the mountpoint being named by the device format type. Changed the mountpoint namer so that it is named after the device name instead. Change required adding BIOS Boot as a name in the mountpoint types to avoid unexpected behavior as a side effect from this change. Resolves: rhbz#1172755
|
When pull requests targeted for multiple branches won't be very different you can just set the 'master' and 'rhel7-branch' labels on it instead of creating multiple pull requests. |
| @@ -203,7 +203,7 @@ def removeSelector(self, selector): | |||
|
|
|||
| def _mountpointType(self, mountpoint): | |||
| if not mountpoint or mountpoint in ["/", "/boot", "/boot/efi", "/tmp", "/usr", "/var", | |||
| "biosboot", "prepboot", "swap"]: | |||
| "swap", "PPC PReP Boot", "BIOS Boot"]: | |||
There was a problem hiding this comment.
Are you sure this works with partitions/devices created by users in custom partitioning? AFAICT we still expect them to type in/choose prepboot as the mountpoint not PPC PReP Boot.
kellinm
added a commit
that referenced
this pull request
Jul 24, 2015
Fix Initial PPC PReP Boot Selector Name (#1172755)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The auto partition tool added the PPC PReP Boot partition and named it
prepboot in the selector view in the GUI installer. This was due to the
mountpoint being named by the device format type. Changed the mountpoint
namer so that it is named after the device name instead.
Change required adding BIOS Boot as a name in the mountpoint types to
avoid unexpected behavior as a side effect from this change.
Resolves: rhbz#1172755