localization: do not crash on failed parsing of X layout (#1836047) #2633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds unit test for the case and more localed wrapper testing (67% -> 98% coverage of localed.py)
jkonecny12
reviewed
Jun 3, 2020
| layouts.append(layout) | ||
| variants.append(variant) | ||
|
|
||
| if not layouts and parsing_failed: | ||
| return | ||
|
|
||
| layouts_str = ",".join(layouts) |
There was a problem hiding this comment.
What will happen here if parsing will be successful but there won't be any layouts?
There was a problem hiding this comment.
Hm, I think it that by the logic here, it can't happen.
Or if you mean the case where the method is called with no nonempty layout_variants, then the behaviour should be preserved (which I think is effectively unsetting the X Layouts by supplying empty strings to the SetX11Keyboard). I don't intend to change it in this PR.
|
jenkins, test this please |
|
jenkins, test this please |
1 similar comment
|
jenkins, test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds unit test for the case and more localed wrapper testing
(67% -> 98% coverage of localed.py)