Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add product data for CentOS Stream #2689

Conversation

bstinsonmhk
Copy link

We need product data for CentOS Stream in addition to CentOS Linux. This is just a copy of the CentOS Linux data with the product_name changed.

Can we be sure this also makes it into a RHEL build of anaconda?

Copy link
Contributor

@poncovka poncovka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some suggestions.

data/product.d/centos-stream.conf Outdated Show resolved Hide resolved
data/product.d/centos-stream.conf Show resolved Hide resolved
@poncovka
Copy link
Contributor

Can we be sure this also makes it into a RHEL build of anaconda?

Please, open a new pull request for the rhel-8 branch. The commit message should contain a line Resolves: rhbz#12345 or Related: rhbz#12345 with a number of the related bugzilla bug.

@poncovka poncovka self-assigned this Jun 26, 2020
@VladimirSlavik VladimirSlavik added the master Please, use the `f39` label instead. label Aug 13, 2020
@VladimirSlavik
Copy link
Contributor

Jenkins, it's ok to test this.

Copy link
Contributor

@VladimirSlavik VladimirSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great but could you please squash these commits? If you don't want to do that, I'm happy to do that ;).

@jkonecny12 jkonecny12 added the notable change Important changes like API change, behavior change... label Aug 13, 2020
Copy link
Contributor

@poncovka poncovka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great. Thanks!

@jkonecny12
Copy link
Member

Hi @bstinsonmhk , do you want me to handle the commit squashing?

@poncovka
Copy link
Contributor

Fixed in #3014.

@poncovka poncovka closed this Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master Please, use the `f39` label instead. notable change Important changes like API change, behavior change...
5 participants