New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add product data for CentOS Stream #2689
Add product data for CentOS Stream #2689
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some suggestions.
Please, open a new pull request for the rhel-8 branch. The commit message should contain a line |
…-inherit Review adjustments for rhinstaller#2689
Jenkins, it's ok to test this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great but could you please squash these commits? If you don't want to do that, I'm happy to do that ;).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great. Thanks!
Hi @bstinsonmhk , do you want me to handle the commit squashing? |
Fixed in #3014. |
We need product data for CentOS Stream in addition to CentOS Linux. This is just a copy of the CentOS Linux data with the product_name changed.
Can we be sure this also makes it into a RHEL build of anaconda?