Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fedora IoT product override #2728

Merged
merged 2 commits into from Jul 16, 2020

Conversation

Conan-Kudo
Copy link
Contributor

Fedora IoT was previously relying on the base Fedora product definition,
but it should not, since it should be using the classic storage configuration.

Fixes https://pagure.io/fedora-iot/issue/31

(cc: @AdamWill, @nullr0ute)

Signed-off-by: Neal Gompa ngompa13@gmail.com

@Conan-Kudo
Copy link
Contributor Author

cc: @cmurf, @davide125

Fedora IoT was previously relying on the base Fedora product definition,
but it should not, since it should be using the classic storage configuration.

Signed-off-by: Neal Gompa <ngompa13@gmail.com>
@poncovka
Copy link
Contributor

Jenkins, it's ok to test.

@poncovka poncovka added manual testing required This issue can't be merged without manual testing master Please, use the `f39` label instead. labels Jul 10, 2020
At the moment, the Fedora release composition process produces an
image that identifies Fedora IoT Edition as "Fedora-IoT" product with
an "IoT" variant, rather than the "IoT" variant of the regular "Fedora"
product.

Until things are fixed, let's just deal with it.

Signed-off-by: Neal Gompa <ngompa13@gmail.com>
Copy link
Contributor

@poncovka poncovka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@poncovka poncovka removed the manual testing required This issue can't be merged without manual testing label Jul 16, 2020
@poncovka poncovka merged commit 104a289 into rhinstaller:master Jul 16, 2020
@Conan-Kudo Conan-Kudo deleted the fedora-iot-product branch July 16, 2020 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master Please, use the `f39` label instead.
4 participants