Fix crash when devices and connections are changing (#1245960) #274
Conversation
| # Configs for ethernet has been already added, | ||
| # this must be some slave | ||
| if dev_cfg.device_type == NetworkManager.DeviceType.ETHERNET: | ||
| # skip slaves - only slaves has master |
There was a problem hiding this comment.
ahh thank you. I'll change this locally
|
Other than the nitpick above this looks good to me. |
| if dev_cfg: | ||
| dev_cfg.device = device | ||
| else: | ||
| # it's wireless or device with missing connection | ||
| # skip device with missing connection now, will be add when connection appears |
There was a problem hiding this comment.
'skip the device'
'will be added'
|
Looks ok to me, other than those subtle little grammar changes. |
|
Ahh thank you @bcl for the grammar correction. |
|
I think we should find the NM device object and set device attribute of DeviceConfiguration when creating it in add_connection_to_list() for ETHERNET device case (ie the case when ethernet device is added). It seems the code assumes the DeviceConfiguration.device to be present for eth devices. Also we should connect callbacks for the device in add_device_to_list, which does not happen due to earlier return before |
Anaconda will crash when user remove existing ethernet connection for the device. This could happen especially in Live compose. Fixed now by skipping devices without connection and add that device after the connection appears. Related: rhbz#1245960
Anaconda will crash when user add a new device in the Welcome screen. This happens because the configuration file for the new device wasn't created. Fixed by generating this configuration in NetworkSpoke initialization. Resolves: rhbz#1245960
jkonecny12
force-pushed
the
master-settings-not-found-usb
branch
from
31a8cb6
to
c1d6d59
Compare
|
Updated PR. |
| self.add_dev_cfg(dev_cfg) | ||
| log.debug("network: GUI, adding connection %s", uuid) | ||
| return True | ||
|
|
||
| def initialize(self): | ||
| # There is a signal for newly added devices from NetworkManager but it | ||
| # is registered after the initialize method. | ||
| # So if someone adds a new device in the Welcome screen the ifconf file won't |
There was a problem hiding this comment.
...the ifcfg file... not ifconf file I believe.
|
Looks good to me other than the nitpick above. But I'm leaving this to @rvykydal for a review as he knows these "waters" much better. :) |
|
Thank you I'll change it locally. |
|
Pushed |
First when user add new device to started anaconda in Welcome screen then
the anaconda will crash in NetworkSpoke initialization. This happens
because it's not created configuration file for the new device.
Fixed by generating this configuration in NetworkSpoke initialization.
Second when user remove existing ethernet connection for device. This could
happen specially in Live compose. This is fixed now that we skipping
devices without connection and add that device after the connection
appears.
Resolves: rhbz#1245960