Change text on the Reset All button in custom part. #2841

VladimirSlavik · 2020-09-09T12:35:26Z

Resolves: rhbz#1163701

Comments welcome. Previously the button said "Reset all".

AdamWill · 2020-09-09T18:33:55Z

Yeah, I think this is definitely an improvement. 👍

poncovka

Looks good to me. Thanks!

M4rtinK

Looks good to me as well, thanks - just a small wording improvement suggestion. :)

M4rtinK · 2020-09-10T10:26:57Z

pyanaconda/ui/gui/spokes/custom_storage.glade

                        <property name="visible">True</property>
                        <property name="sensitive">False</property>
                        <property name="can_focus">True</property>
                        <property name="receives_default">True</property>
+                        <property name="tooltip_text" translatable="yes" context="GUI|Custom Partitioning">Return to the state before any changes.</property>


I wonder if "Roll back any changes" would be better ?

~~Definitely!~~ On a second though, that says the same as the button text?

ShwetaNaresh · 2020-09-10T15:02:05Z

How about any of the following?
Restore Default Settings | Cancel All | Discard Changes

AdamWill · 2020-09-10T17:54:22Z

Definitely not "Restore Default Settings" because there are no default settings here. The operation we're describing is just cancelling all planned disk device changes in the installer. The existing state is "whatever state the disks are currently in". That's not something that can sensibly be described as a "default".

ShwetaNaresh · 2020-09-10T19:11:22Z

How about 'Restore Disk State'? 'Discard Changes' is more generic.

AdamWill · 2020-09-10T19:17:49Z

That goes back to the initial problem of implying some kind of actual possibly-scary operation, I think. That's why we don't like "Reset All" - it can be ready as implying that clicking the button will actually do something possibly-scary to the disks. We need to try and make the new text avoid that as much as possible.

VladimirSlavik · 2020-09-11T08:27:26Z

One more idea, Undo all changes.

Keep in mind the tooltip also needs some ideas. That can be longer.

jkonecny12 · 2020-09-11T09:28:18Z

One more idea, Undo all changes.

Maybe
Undo all planned actions.

Keep in mind the tooltip also needs some ideas. That can be longer.

What about
Return partitioning to the original state before user made any changes. This is not destructive operation.

ShwetaNaresh · 2020-09-11T09:39:35Z

IMO, with 'Undo All' we are discarding all changes, so in general term it could be labelled as 'Discard Changes'.
IMO, 'Undo' is generally considered to reset any previous action, and is represented more as an icon.

AdamWill · 2020-09-11T19:04:37Z

Yeah, I quite like "discard" in this case.

Resolves: rhbz#1163701

VladimirSlavik · 2020-09-22T11:43:58Z

Let's have the Discard variant... First comment edited for updated screenshot too.

jkonecny12 · 2020-09-22T16:15:48Z

Maybe I would remove the you in the tooltip. Something like:
...before any changes has been made...

Seems more formal to me.

ShwetaNaresh · 2020-09-22T18:04:52Z

Hi Jirka, Please can I know what tool tip are you referring to? Regards Shweta

…

On Tue, Sep 22, 2020, 6:16 PM Jiri Konecny ***@***.***> wrote: Maybe I would remove the you in the tooltip. Something like: ...before any changes has been made... Seems more formal to me. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2841 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMBFMTZPKYRGANI45PXMV6LSHDEULANCNFSM4RCEEFMA> .

jkonecny12 · 2020-09-23T10:26:21Z

Hi Jirka, Please can I know what tool tip are you referring to? Regards Shweta
…
On Tue, Sep 22, 2020, 6:16 PM Jiri Konecny @.***> wrote: Maybe I would remove the you in the tooltip. Something like: ...before any changes has been made... Seems more formal to me. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2841 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMBFMTZPKYRGANI45PXMV6LSHDEULANCNFSM4RCEEFMA .

Tooltip on the screenshot here #2841 (comment) . Basically text which will show up when you hover mouse over the button.

poncovka

It looks great Thanks!

ShwetaNaresh · 2020-09-23T13:17:37Z

Thank you, Jirka! Just a few thoughts: - IMO, the button name is self explanatory. We can probably do away with the tool tip. Also, tool tips are generally used for icons or to define new or unfamiliar UI elements that aren’t described directly in the user interface, or to get additional data from a data point or element in a chart or table. In the current context, if at all we do need to highlight the operation, it would be good to include it in the on-screen text. - I presume any changes to the screen layout would be out of scope, but it would be good to rephrase some text on the screen. For example, (with bare minimum changes to the screen layout) - Remove the heading 'New Fedora Rawhide Installation' from the box on the left hand side. We already have this text on the top right corner of the page. - Rephrase the text in the LHS box to: +++++ Create the disk mount points and then select a partitioning scheme. You can choose to create the mount points manually or use an automated method. To manually create the mount points, click +. To use an automated method, click *Create mount points automatically*. *Partitioning scheme*: <*Dropdown list here*> +++++++ - Rephrase the text in the RHS box to: +++++++ Details about the mount points that you create are displayed here. To discard the created mount points and partitions, click *Discard All Changes*. This operation resets the disk to its original state. +++++++ Regards Shweta On Wed, Sep 23, 2020 at 12:26 PM Jiri Konecny <notifications@github.com> wrote:

…

Hi Jirka, Please can I know what tool tip are you referring to? Regards Shweta … <#m_5817298734678833314_> On Tue, Sep 22, 2020, 6:16 PM Jiri Konecny *@*.***> wrote: Maybe I would remove the you in the tooltip. Something like: ...before any changes has been made... Seems more formal to me. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2841 (comment) <#2841 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMBFMTZPKYRGANI45PXMV6LSHDEULANCNFSM4RCEEFMA . Tooltip on the screenshot here #2841 (comment) <#2841 (comment)> . Basically text which will show up when you hover mouse over the button. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2841 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMBFMT5NQZBDRWLUOAT7K7LSHHENZANCNFSM4RCEEFMA> .

VladimirSlavik added the master Please, use the `f39` label instead. label Sep 9, 2020

VladimirSlavik force-pushed the master-reset-all-new-name branch 2 times, most recently from 0fa5976 to a1092b9 Compare September 9, 2020 12:44

poncovka added the notable change Important changes like API change, behavior change... label Sep 9, 2020

poncovka approved these changes Sep 10, 2020

View reviewed changes

M4rtinK approved these changes Sep 10, 2020

View reviewed changes

Change text on the Reset All button in custom part.

4f92dd2

Resolves: rhbz#1163701

VladimirSlavik force-pushed the master-reset-all-new-name branch from a1092b9 to 4f92dd2 Compare September 22, 2020 11:41

poncovka approved these changes Sep 23, 2020

View reviewed changes

VladimirSlavik merged commit a3a9b57 into rhinstaller:master Sep 24, 2020

VladimirSlavik deleted the master-reset-all-new-name branch September 24, 2020 15:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change text on the Reset All button in custom part. #2841

Change text on the Reset All button in custom part. #2841

VladimirSlavik commented Sep 9, 2020 •

edited

Loading

AdamWill commented Sep 9, 2020

poncovka left a comment

M4rtinK left a comment

M4rtinK Sep 10, 2020

VladimirSlavik Sep 10, 2020 •

edited

Loading

ShwetaNaresh commented Sep 10, 2020

AdamWill commented Sep 10, 2020

ShwetaNaresh commented Sep 10, 2020

AdamWill commented Sep 10, 2020

VladimirSlavik commented Sep 11, 2020

jkonecny12 commented Sep 11, 2020

ShwetaNaresh commented Sep 11, 2020

AdamWill commented Sep 11, 2020

VladimirSlavik commented Sep 22, 2020 •

edited

Loading

jkonecny12 commented Sep 22, 2020

ShwetaNaresh commented Sep 22, 2020 via email

jkonecny12 commented Sep 23, 2020

poncovka left a comment

ShwetaNaresh commented Sep 23, 2020 via email

Change text on the Reset All button in custom part. #2841

Change text on the Reset All button in custom part. #2841

Conversation

VladimirSlavik commented Sep 9, 2020 • edited Loading

AdamWill commented Sep 9, 2020

poncovka left a comment

Choose a reason for hiding this comment

M4rtinK left a comment

Choose a reason for hiding this comment

M4rtinK Sep 10, 2020

Choose a reason for hiding this comment

VladimirSlavik Sep 10, 2020 • edited Loading

Choose a reason for hiding this comment

ShwetaNaresh commented Sep 10, 2020

AdamWill commented Sep 10, 2020

ShwetaNaresh commented Sep 10, 2020

AdamWill commented Sep 10, 2020

VladimirSlavik commented Sep 11, 2020

jkonecny12 commented Sep 11, 2020

ShwetaNaresh commented Sep 11, 2020

AdamWill commented Sep 11, 2020

VladimirSlavik commented Sep 22, 2020 • edited Loading

jkonecny12 commented Sep 22, 2020

ShwetaNaresh commented Sep 22, 2020 via email

jkonecny12 commented Sep 23, 2020

poncovka left a comment

Choose a reason for hiding this comment

ShwetaNaresh commented Sep 23, 2020 via email

VladimirSlavik commented Sep 9, 2020 •

edited

Loading

VladimirSlavik Sep 10, 2020 •

edited

Loading

VladimirSlavik commented Sep 22, 2020 •

edited

Loading