Remove the support for changing the log level #2864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poncovka
added
master
VladimirSlavik
previously approved these changes
Sep 21, 2020
|
Jenkins, test this please. |
jkonecny12
approved these changes
Sep 23, 2020
jkonecny12
reviewed
Sep 23, 2020
poncovka
force-pushed
the
master-remove_log_level_support
branch
from
8b872bf
to
fed23cb
Compare
|
Blocked by pykickstart. |
jkonecny12
approved these changes
Oct 2, 2020
|
Jenkins, test this please. |
jkonecny12
requested changes
Oct 2, 2020
anaconda.spec.in
Outdated
| @@ -35,7 +35,7 @@ Source0: %{name}-%{version}.tar.bz2 | |||
| %define libxklavierver 5.4 | |||
| %define mehver 0.23-1 | |||
| %define nmver 1.0 | |||
| %define pykickstartver 3.28-1 | |||
| %define pykickstartver 3.31-1 | |||
There was a problem hiding this comment.
Please this should be 3.30 version.
There was a problem hiding this comment.
The fix hasn't been released yet.
poncovka
removed
the
manual testing required
jkonecny12
previously approved these changes
Oct 2, 2020
There is no handler that allows to change its log level. The last one was the file handler for /tmp/packaging.log. Since the commit a2ae719, all handlers have their log levels set to DEBUG all the time.
poncovka
dismissed stale reviews from jkonecny12 and VladimirSlavik
via
10e05e9
poncovka
force-pushed
the
master-remove_log_level_support
branch
from
fed23cb
to
10e05e9
Compare
|
Rebased. I will open another pull request for the kickstart command. |
The support for this option doesn't work for a while.
The storage logger is no longer used. The logging is handled by the Storage module.
poncovka
force-pushed
the
master-remove_log_level_support
branch
from
10e05e9
to
7981514
Compare
vojtechtrefny
added a commit
to vojtechtrefny/lorax
that referenced
this pull request
Nov 18, 2020
This option has been removed, see rhinstaller/anaconda#2864
bcl
pushed a commit
to weldr/lorax
that referenced
this pull request
Nov 18, 2020
This option has been removed, see rhinstaller/anaconda#2864
bcl
pushed a commit
to weldr/lorax
that referenced
this pull request
Dec 2, 2020
This option has been removed, see rhinstaller/anaconda#2864
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no handler that allows to change its log level. The last one was the
file handler for /tmp/packaging.log. Since the commit a2ae719, all handlers
have their log levels set to DEBUG all the time.
Remove the
logleveloption.Deprecate the
--leveloption of theloggingkickstart command.Depends on: pykickstart/pykickstart#341