Process network kickstart in stage 2 #2870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvykydal
force-pushed
the
process-network-kickstart-in-stage-2
branch
from
4344042
to
7e53198
Compare
poncovka
approved these changes
Sep 29, 2020
jkonecny12
approved these changes
Sep 29, 2020
|
/packit build |
VladimirSlavik
approved these changes
Oct 2, 2020
No more needed with kickstart processed in stage 2.
No more needed with NetworkManager in initramfs - taking connections over seems to be seamless.
…ection It is possible that the mechanism for device renaming via DEVICE and HWADDR values in ifcfg files will be abandoned, but for now we need to keep it supported. With kickstart not applied in intiramfs we need to take it into account when updating a connection from initramfs for a device renamed via ifname=.
Kickstart will be applied after switch root by the mechanism which so far served for network configuration via %pre.
rvykydal
force-pushed
the
process-network-kickstart-in-stage-2
branch
from
7e53198
to
0da378c
Compare
|
I've replaced the first two commits and rebased the branch to the current master. |
poncovka
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first comit is already on f33-devel.For the second there is a PR for f33-devel.I will remove them after merging them into master with f33-devel.All the restThe PR is only for master (so we catch fallouts before getting into Fedora 34) where we move from:A: Network kickstart parsed in initramfs into ifcfg files based on which NM started after switch root creates and activates the respective connections.
to:
B: Network kickstart parsed in Anaconda after switch root which creates and activates NM connections via NM API.
The B: is what we already used to do for networking configured in %pre section so it has already got some usage and testing. We just needed to add a few more complex cases (eg vlan over bond).
The change from A to B was made possible by NM replacing dracut network module in initramfs.
The PR makes the code fully independent of the configuration format NM is using (ifcfg file of keyfile). Also network configuration (and perhaps Anaconda as whole) is no more dependent on fedora-import-service (passing configuration files from initramfs to rootfs), which used to cause issues like rhbz#1537977. Also it allows to get rid of hacks around ONBOOT value used for activating/not activating ifcfgs created in initramfs by NM.
The only thing that is changing with this PR is that NM default autoconnections are no more blocked from being created by ifcfgs with ONBOOT=no created in initramfs.