Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove autostep functionality #2978

Merged

Conversation

VladimirSlavik
Copy link
Contributor

@VladimirSlavik VladimirSlavik commented Nov 5, 2020

Autostep did not work for some time already, this merely removes the no longer used code. Automatic screenshots are gone with this, too. Manual screenshots remain available.


This was so much code, it was expensive to write... and now...

Throw away

Autostep did not work for some time already, this merely removes the no longer
used code. Automatic screenshots are gone with this, too. Manual screenshots
remain available.
@VladimirSlavik VladimirSlavik added master Please, use the `f39` label instead. manual testing required This issue can't be merged without manual testing labels Nov 5, 2020
@pep8speaks
Copy link

Hello @VladimirSlavik! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 44:1: E402 module level import not at top of file

Copy link
Contributor

@poncovka poncovka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great. Thanks!

@VladimirSlavik VladimirSlavik removed the manual testing required This issue can't be merged without manual testing label Nov 9, 2020
Copy link
Contributor

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well - a really nice cleanup! :)

@VladimirSlavik VladimirSlavik merged commit fd8b895 into rhinstaller:master Nov 10, 2020
@VladimirSlavik VladimirSlavik deleted the master-remove-autostep branch November 10, 2020 16:23
@jkonecny12
Copy link
Member

I love commits which removes more than add :)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master Please, use the `f39` label instead.
5 participants