Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deviceprobe and install commands #2985

Merged
merged 1 commit into from Nov 12, 2020
Merged

Remove deviceprobe and install commands #2985

merged 1 commit into from Nov 12, 2020

Conversation

VladimirSlavik
Copy link
Contributor

They have been deprecated a long time ago.

@VladimirSlavik
Remove deviceprobe and install commands
dbf956e 
They have been deprecated a long time ago.
@VladimirSlavik VladimirSlavik added master Please, use the `f39` label instead. notable change Important changes like API change, behavior change... labels Nov 9, 2020
@VladimirSlavik
Copy link
Contributor Author

See also pykickstart/pykickstart#347

poncovka
poncovka approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@poncovka poncovka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@jstodola
Copy link
Contributor

Can you please wait a bit before merging this PR? Although the install command has been deprecated for a while, this change would cause problems for installations via Beaker (https://beaker-project.org/), where the install command is still provided in the kickstart file even for rawhide.
Bug against Beaker: https://bugzilla.redhat.com/show_bug.cgi?id=1896479

@VladimirSlavik
Copy link
Contributor Author

Sure, let's do that.

However, specifically this change does not matter. It's only two lines because even before, the commands did not do anything. It's the pykickstart change that actually changes outward behavior - that makes these commands not parse.

@poncovka
Copy link
Contributor

This PR is safe to merge, because it only removes some unused imports. I don't think it's a notable change.

@VladimirSlavik
Copy link
Contributor Author

I'd be happy to drop the label and merge right away. However, I am not sure if we have any good mechanism to announce that an important change is coming, except it's really in pykickstart.

@jstodola
Copy link
Contributor

OK, feel free to merge this change, I will follow the pykickstart PR to avoid unpleasant surprises before the Beaker bug is resolved.
Sorry for the noise :-)

@VladimirSlavik VladimirSlavik merged commit d35fbe7 into rhinstaller:master Nov 12, 2020
@VladimirSlavik VladimirSlavik deleted the master-remove-install-and-deviceprobe branch November 12, 2020 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poncovka poncovka poncovka approved these changes

Assignees
No one assigned
Labels
master Please, use the `f39` label instead. notable change Important changes like API change, behavior change...
Milestone
No milestone
3 participants
@VladimirSlavik @jstodola @poncovka