Handle disabled and failing add-ons #2988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poncovka
force-pushed
the
master-support_disabled_addons
branch
from
dc560a5
to
ffad7b2
Compare
VladimirSlavik
previously approved these changes
Nov 12, 2020
jkonecny12
previously approved these changes
Nov 12, 2020
If the Python module started by the start-module script fails before the timeout of sixty seconds, return its exit status. Otherwise, return zero. This will speed up the propagation of the error to the boss. Otherwise, we wait for the timeout of service_start_timeout defined by the Anaconda message bus. The start-module script runs in a separate process and doesn't block the message bus, the boss or the installer.
If the add-on fails to start, just remove it from the list of available modules and continue. Don't abort the whole installation because of that. This fix will allow the kdump add-on to refuse to run its DBus module if it is not enabled via the inst.kdump_addon boot option.
poncovka
dismissed stale reviews from jkonecny12 and VladimirSlavik
via
4f9fe31
poncovka
force-pushed
the
master-support_disabled_addons
branch
from
ffad7b2
to
4f9fe31
Compare
|
Rebased to fix the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the add-on started by the
start-modulescript fails before thetimeout of sixty seconds, return its exit status. Otherwise, return zero.
If the add-on fails to start, just remove it from the list of available modules
and continue. Don't abort the whole installation because of that.
This will allow the kdump add-on to refuse to run its DBus module if it is
not enabled via the
inst.kdump_addonboot option.