Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the priority of the ostreesetup kickstart command (#1896761) #2990

Merged

Conversation

poncovka
Copy link
Contributor

Keep the same priorities as in the payload property of the Anaconda class.
If ostreesetup is in the kickstart file, always create the RPM OSTree module.

Resolves: rhbz#1896761

@poncovka poncovka added master Please, use the `f39` label instead. manual testing required This issue can't be merged without manual testing labels Nov 11, 2020
@pep8speaks
Copy link

pep8speaks commented Nov 11, 2020

Hello @poncovka! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 97:100: E501 line too long (111 > 99 characters)

Comment last updated at 2020-11-12 14:34:20 UTC

@poncovka poncovka removed the manual testing required This issue can't be merged without manual testing label Nov 12, 2020
Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. LGTM!

jkonecny12
jkonecny12 previously approved these changes Nov 12, 2020
VladimirSlavik
VladimirSlavik previously approved these changes Nov 12, 2020
Copy link
Contributor

@VladimirSlavik VladimirSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

Keep the same priorities as in the payload property of the Anaconda class.
If ostreesetup is in the kickstart file, always create the RPM OSTree module.

Resolves: rhbz#1896761
@poncovka
Copy link
Contributor Author

/packit build

@poncovka
Copy link
Contributor Author

Rebased to fix the tests.

@poncovka poncovka merged commit 21020cf into rhinstaller:master Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master Please, use the `f39` label instead.
4 participants