Reorganize the error handler #3056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poncovka
added
master
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
|
Code looks far better, but won't our users miss all the wonderful detail in error popups? |
jkonecny12
requested changes
Jan 4, 2021
M4rtinK
approved these changes
Jan 4, 2021
poncovka
force-pushed
the
master-payload_error_handler
branch
2 times, most recently
from
d9970b6
to
d88f148
Compare
|
/kickstart-test --testtype coverage |
jkonecny12
requested changes
Jan 6, 2021
We shouldn't handle errors in the code that is run by the installation tasks.
If the password cannot be encrypted with the specified algorithm, it is a bug.
We should fail to set up the source and report that to the user instead. The mountImage function is called only from the _find_and_mount_iso method with a normalized path of an ISO file. Therefore, we can remove the mountImage function and use the mount function from the payload utils instead.
poncovka
force-pushed
the
master-payload_error_handler
branch
from
d88f148
to
a1de0e3
Compare
We should fail to set up the source and report that to the user instead.
We are able to handle unknown groups. This is always a bug.
Move the mapping into an attribute and rename some of the handlers.
If there is no callback, then there is nothing to handle. We will always raise the exception.
Let the installation task handle the exception raised in the code. Any PayloadError exception is fatal anyway.
Rename the method to _handle_marking_error.
There is no InstallMoreStreamsException class in dnf.exceptions and the NoStreamSpecifiedException class is not used by DNF.
Show a dialog window that informs a user why the non-package payload couldn't be set up. There is no UI support that could handle the error state, so we need to handle or raise the error directly. Make sure that payloads raise the right exception from the setup method.
Log the IPMI events, so we can debug them when IPMI is not supported.
Make sure that we always report an IPMI event before calling sys.exit. Fix some of the exit codes since the installation cannot be successful in this case.
Make sure that exit dialog windows report an IPMI event before calling sys.exit. TUI already works this way, so we just need to fix GUI to work the same way.
poncovka
force-pushed
the
master-payload_error_handler
branch
from
a1de0e3
to
b6d9133
Compare
|
/kickstart-test --testtype coverage |
poncovka
removed
the
manual testing required
|
All issues should be resolved and the code is tested. |
jkonecny12
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are not able to use the error handler in the DBus modules, so move
it from the low-level code to the top level if possible, so we don't have to
deal with it during the Anaconda modularization.
Remove error handlers for deprecated or invalid use cases and clean up
the code.