Fix root password and LUKS passphrase visibility toggle (#1911360) #3119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anaconda supports showing a little "eye" icon in the password/passphrase entry field that can be used to make the entered text visible in plaintext during entry. For this to work correctly entry text visibility state needs to be set correctly. This has been broken by some of the password/passphrase entry related refactorings in the recent past, resulting in the "eye" icon not being visible. So put the initialization back for the root password and LUKS passphrase entries and also extend the docstring in the user configuration spoke to note how password visibility influences the toggle icon. Resolves: rhbz#1911360
|
So this is how it looks like with the fix: |
poncovka
approved these changes
Jan 25, 2021
|
/kickstart-test --testtype smoke |
VladimirSlavik
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anaconda supports showing a little "eye" icon in the password/passphrase
entry field that can be used to make the entered text visible in
plaintext during entry.
For this to work correctly entry text visibility state needs to be
set correctly. This has been broken by some of the password/passphrase
entry related refactorings in the recent past, resulting in the "eye"
icon not being visible.
So put the initialization back for the root password and LUKS passphrase
entries and also extend the docstring in the user configuration spoke
to note how password visibility influences the toggle icon.
Resolves: rhbz#1911360