Add support for non-critical installation errors #3147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poncovka
added
master
pyanaconda/errors.py
Outdated
Comment on lines
212
to
214
| message = _("The following error occurred during the installation:") | ||
| message += "\n\n" + str(exn) + "\n\n" | ||
| message = _("Would you like to ignore this and continue with installation?") |
There was a problem hiding this comment.
As a translator, I would definitely prefer one string to many small pieces. If it's not inconvenient, please make it one string with format or concatenation, as in the handlers above.
The OSCAP add-on needs to be able to raise a non-critical installation error. In that case, the users should be allowed to continue with the installation if they want to.
poncovka
force-pushed
the
master-non_critical_errors
branch
from
d214acb
to
f1ce918
Compare
|
|
poncovka
removed
the
manual testing required
VladimirSlavik
approved these changes
Feb 5, 2021
|
/kickstart-test --testtype smoke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OSCAP add-on needs to be able to raise a non-critical installation error.
In that case, the users should be allowed to continue with the installation
if they want to.